Source/core/rendering/RenderLayerModelObject.cpp - Issue 160903002: Move RenderLayer repainting to repaint-after-layout framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerModelObject.cpp

Issue 160903002: Move RenderLayer repainting to repaint-after-layout framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Rebase to master Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderBox.cpp ('K') | « Source/core/rendering/RenderLayer.cpp ('k') | Source/core/rendering/RenderLayerRepainter.cpp » ('j') | Source/core/rendering/RenderLayerRepainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayerModelObject.cpp

diff --git a/Source/core/rendering/RenderLayerModelObject.cpp b/Source/core/rendering/RenderLayerModelObject.cpp

index 82b423b6d1e9e948e10fed043cf89f8d26c50929..ca00211dc54fe1a98317f4b467a6fec3984aa12e 100644

--- a/Source/core/rendering/RenderLayerModelObject.cpp

+++ b/Source/core/rendering/RenderLayerModelObject.cpp

@@ -148,7 +148,12 @@ void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderSt

setChildNeedsLayout();

createLayer(type);

if (parent() && !needsLayout() && containingBlock()) {

- layer()->repainter().setRepaintStatus(NeedsFullRepaint);

+ // FIXME: This invalidation is overly broad. We should update to

+ // do the correct invalidation at RenderStyle::diff time. crbug.com/349061

+ if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled())

+ layer()->renderer()->setShouldDoFullRepaintAfterLayout(true);

+ else

+ layer()->repainter().setRepaintStatus(NeedsFullRepaint);

// There is only one layer to update, it is not worth using |cachedOffset| since

// we are not sure the value will be used.

layer()->updateLayerPositions(0);