Move RenderLayer repainting to repaint-after-layout framework.

Source/core/rendering/RenderBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 268 matching lines @@
     setFloating(!isOutOfFlowPositioned() && styleToUse->isFloating());
 
     bool boxHasOverflowClip = false;
     if (!styleToUse->isOverflowVisible() && isRenderBlock() && !isViewObject) {
         // If overflow has been propagated to the viewport, it has no effect here.
         if (node() != document().viewportDefiningElement()) {
             boxHasOverflowClip = true;
             if (!hasOverflowClip()) {
                 // If we are getting an overflow clip, preemptively erase any overflowing content.
                 // FIXME: This should probably consult RenderOverflow.
-                repaint();
+                if (!RuntimeEnabledFeatures::repaintAfterLayoutEnabled())
+                    repaint();
             }
         }
     }
+
+    if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled() && (boxHasOverflowClip != hasOverflowClip())) {
+        // FIXME: This shouldn't be required if we tracked the visual overflow
+        // generated by positioned children or self painting layers. crbug.com/345403
+        for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {

[esprehn, 2014/02/28 02:54:33]

You can't do this, you're looking at your children in the middle of recalcStyle.

[dsinclair, 2014/02/28 18:58:24]

Changed to storing a flag here and checking the isSelfPaintingLayer() when we do
FrameView::repaintTree().

+            if (child->hasLayer() && toRenderLayerModelObject(child)->layer()->isSelfPaintingLayer()) {
+                LayoutRectRecorder childRecorder(*child);
+                child->setShouldDoFullRepaintAfterLayout(true);
+            }
+        }
+    }
+
     setHasOverflowClip(boxHasOverflowClip);
 
     setHasTransform(styleToUse->hasTransformRelatedProperty());
     setHasReflection(styleToUse->boxReflect());
 }
 
 void RenderBox::layout()
 {
     ASSERT(needsLayout());
 
@@ skipping 1261 matching lines @@
     }
 
     return false;
 }
 
 void RenderBox::imageChanged(WrappedImagePtr image, const IntRect*)
 {
     if (!parent())
         return;
 
+    AllowRepaintScope scoper(frameView());
+
     if ((style()->borderImage().image() && style()->borderImage().image()->data() == image) ||
         (style()->maskBoxImage().image() && style()->maskBoxImage().image()->data() == image)) {
         repaint();
         return;
     }
 
     ShapeValue* shapeOutsideValue = style()->shapeOutside();
     if (!frameView()->isInPerformLayout() && isFloating() && shapeOutsideValue && shapeOutsideValue->image() && shapeOutsideValue->image()->data() == image) {
         ShapeOutsideInfo::ensureInfo(this)->dirtyShapeSize();
         markShapeOutsideDependentsForLayout();
@@ skipping 3115 matching lines @@
         return 0;
 
     if (!layoutState && !flowThreadContainingBlock())
         return 0;
 
     RenderBlock* containerBlock = containingBlock();
     return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop();
 }
 
 } // namespace WebCore