Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Source/core/rendering/RenderLayerModelObject.cpp

Issue 160903002: Move RenderLayer repainting to repaint-after-layout framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010, 2012 Google Inc. All rights reserved. 7 * Copyright (C) 2010, 2012 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 RenderObject::styleDidChange(diff, oldStyle); 141 RenderObject::styleDidChange(diff, oldStyle);
142 updateFromStyle(); 142 updateFromStyle();
143 143
144 LayerType type = layerTypeRequired(); 144 LayerType type = layerTypeRequired();
145 if (type != NoLayer) { 145 if (type != NoLayer) {
146 if (!layer() && layerCreationAllowedForSubtree()) { 146 if (!layer() && layerCreationAllowedForSubtree()) {
147 if (s_wasFloating && isFloating()) 147 if (s_wasFloating && isFloating())
148 setChildNeedsLayout(); 148 setChildNeedsLayout();
149 createLayer(type); 149 createLayer(type);
150 if (parent() && !needsLayout() && containingBlock()) { 150 if (parent() && !needsLayout() && containingBlock()) {
151 layer()->repainter().setRepaintStatus(NeedsFullRepaint); 151 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled())
152 layer()->renderer()->setShouldDoFullRepaintAfterLayout(true) ;
Julien - ping for review 2014/03/04 18:22:10 This seems overly broad as we could get a layer wi
dsinclair 2014/03/04 19:21:52 Add a FIXME and crbug.com/349061.
153 else
154 layer()->repainter().setRepaintStatus(NeedsFullRepaint);
152 // There is only one layer to update, it is not worth using |cac hedOffset| since 155 // There is only one layer to update, it is not worth using |cac hedOffset| since
153 // we are not sure the value will be used. 156 // we are not sure the value will be used.
154 layer()->updateLayerPositions(0); 157 layer()->updateLayerPositions(0);
155 } 158 }
156 } 159 }
157 } else if (layer() && layer()->parent()) { 160 } else if (layer() && layer()->parent()) {
158 setHasTransform(false); // Either a transform wasn't specified or the ob ject doesn't support transforms, so just null out the bit. 161 setHasTransform(false); // Either a transform wasn't specified or the ob ject doesn't support transforms, so just null out the bit.
159 setHasReflection(false); 162 setHasReflection(false);
160 layer()->removeOnlyThisLayer(); // calls destroyLayer() which clears m_l ayer 163 layer()->removeOnlyThisLayer(); // calls destroyLayer() which clears m_l ayer
161 if (s_wasFloating && isFloating()) 164 if (s_wasFloating && isFloating())
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 return m_layer ? m_layer->hasCompositedLayerMapping() : false; 217 return m_layer ? m_layer->hasCompositedLayerMapping() : false;
215 } 218 }
216 219
217 CompositedLayerMapping* RenderLayerModelObject::groupedMapping() const 220 CompositedLayerMapping* RenderLayerModelObject::groupedMapping() const
218 { 221 {
219 return m_layer ? m_layer->groupedMapping() : 0; 222 return m_layer ? m_layer->groupedMapping() : 0;
220 } 223 }
221 224
222 } // namespace WebCore 225 } // namespace WebCore
223 226
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698