Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1609023003: Revert of [builtins] Migrate Object.getOwnPropertyDescriptor to C++. (Closed)

Created:
4 years, 11 months ago by Michael Hablich
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Migrate Object.getOwnPropertyDescriptor to C++. (patchset #1 id:1 of https://codereview.chromium.org/1606783002/ ) Reason for revert: Breaks roll: https://codereview.chromium.org/1603953002/ Original issue's description: > [builtins] Migrate Object.getOwnPropertyDescriptor to C++. > > The implementation of Object.getOwnPropertyDescriptor always called into > C++ anyway, so there's no need to have this JavaScript wrapper around at > all. > > R=yangguo@chromium.org > > Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 > Cr-Commit-Position: refs/heads/master@{#33379} TBR=yangguo@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/654a63e1e120b46339075c8de9371e85c71130e9 Cr-Commit-Position: refs/heads/master@{#33404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +7 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Hablich
Created Revert of [builtins] Migrate Object.getOwnPropertyDescriptor to C++.
4 years, 11 months ago (2016-01-20 08:35:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609023003/1
4 years, 11 months ago (2016-01-20 08:36:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609023003/1
4 years, 11 months ago (2016-01-20 11:55:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 12:29:53 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 12:30:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/654a63e1e120b46339075c8de9371e85c71130e9
Cr-Commit-Position: refs/heads/master@{#33404}

Powered by Google App Engine
This is Rietveld 408576698