Roll src/third_party/boringssl/src afe57cb14..6c22f542f

Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7765d1adc67035..6c22f542f42eccb0de7f43edf27aa1255c7be7e2

As this pulls in a new ECDH curve, add X25519 to histograms.xml. Also fix
OPENSSL_SMALL definition in GYP. direct_dependent_settings doesn't apply to the
current target (oops). It also no longer needs to be exported; no test or
header file depends on it anymore.

BUG=571231
Committed: https://crrev.com/8dcde7eb270e9e917ebd0ebade754a8351d4db0b
Cr-Commit-Position: refs/heads/master@{#370617}

[davidben, 2016-01-20 23:21:46]

davidben@chromium.org changed reviewers:
+ agl@chromium.org, isherman@chromium.org

[davidben, 2016-01-20 23:21:46]

isherman for tools/metrics/histograms.xml

[davidben, 2016-01-20 23:22:39]

https://codereview.chromium.org/1608963004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1608963004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:61123: +  <int value="29"
label="X25519"/>
See https://boringssl.googlesource.com/boringssl/+/master/ssl/internal.h#531

(secp256r1 is another name for P-256, etc.)

[davidben, 2016-01-20 23:24:18]

Description was changed from

==========
Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7...

As this pulls in a new ECDH curve, add X25519 to histograms.xml.

BUG=none
==========

to

==========
Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7...

As this pulls in a new ECDH curve, add X25519 to histograms.xml.

BUG=571231
==========

[Ilya Sherman, 2016-01-20 23:27:02]

https://codereview.chromium.org/1608963004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1608963004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:61123: +  <int value="29"
label="X25519"/>
On 2016/01/20 23:22:39, davidben wrote:
> See https://boringssl.googlesource.com/boringssl/+/master/ssl/internal.h#531
> 
> (secp256r1 is another name for P-256, etc.)

I'm curious why 26-28 were skipped, but LGTM.

[agl, 2016-01-20 23:28:12]

lgtm

[davidben, 2016-01-20 23:30:53]

https://codereview.chromium.org/1608963004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1608963004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:61123: +  <int value="29"
label="X25519"/>
On 2016/01/20 23:27:02, Ilya Sherman wrote:
> On 2016/01/20 23:22:39, davidben wrote:
> > See https://boringssl.googlesource.com/boringssl/+/master/ssl/internal.h#531
> > 
> > (secp256r1 is another name for P-256, etc.)
> 
> I'm curious why 26-28 were skipped, but LGTM.

They're allocated to some brainpool curves that we're not going to implement.
:-) Likewise the values below 23 are pretty useless.

[davidben, 2016-01-20 23:31:42]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-01-20 23:34:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608963004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608963004/1

[commit-bot: I haz the power, 2016-01-21 00:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 00:44:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2016-01-21 01:02:42]

Description was changed from

==========
Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7...

As this pulls in a new ECDH curve, add X25519 to histograms.xml.

BUG=571231
==========

to

==========
Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7...

As this pulls in a new ECDH curve, add X25519 to histograms.xml. Also fix
OPENSSL_SMALL definition in GYP. direct_dependent_settings doesn't apply to the
current target (oops). It also no longer needs to be exported; no test or
header file depends on it anymore.

BUG=571231
==========

[davidben, 2016-01-21 01:03:39]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-01-21 01:03:40]

The patchset sent to the CQ was uploaded after l-g-t-m from agl@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1608963004/#ps20001
(title: "Fix OPENSSL_SMALL definition")

[commit-bot: I haz the power, 2016-01-21 01:08:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608963004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608963004/20001

[commit-bot: I haz the power, 2016-01-21 02:08:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 02:08:20]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2016-01-21 02:11:33]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-01-21 02:11:34]

The patchset sent to the CQ was uploaded after l-g-t-m from agl@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1608963004/#ps40001
(title: "Fix gn")

[commit-bot: I haz the power, 2016-01-21 02:12:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608963004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608963004/40001

[commit-bot: I haz the power, 2016-01-21 04:15:45]

Description was changed from

==========
Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7...

As this pulls in a new ECDH curve, add X25519 to histograms.xml. Also fix
OPENSSL_SMALL definition in GYP. direct_dependent_settings doesn't apply to the
current target (oops). It also no longer needs to be exported; no test or
header file depends on it anymore.

BUG=571231
==========

to

==========
Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7...

As this pulls in a new ECDH curve, add X25519 to histograms.xml. Also fix
OPENSSL_SMALL definition in GYP. direct_dependent_settings doesn't apply to the
current target (oops). It also no longer needs to be exported; no test or
header file depends on it anymore.

BUG=571231
==========

[commit-bot: I haz the power, 2016-01-21 04:15:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-21 04:17:48]

Description was changed from

==========
Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7...

As this pulls in a new ECDH curve, add X25519 to histograms.xml. Also fix
OPENSSL_SMALL definition in GYP. direct_dependent_settings doesn't apply to the
current target (oops). It also no longer needs to be exported; no test or
header file depends on it anymore.

BUG=571231
==========

to

==========
Roll src/third_party/boringssl/src afe57cb14..6c22f542f

https://boringssl.googlesource.com/boringssl/+log/afe57cb14d36f70ad4a109fc5e7...

As this pulls in a new ECDH curve, add X25519 to histograms.xml. Also fix
OPENSSL_SMALL definition in GYP. direct_dependent_settings doesn't apply to the
current target (oops). It also no longer needs to be exported; no test or
header file depends on it anymore.

BUG=571231

Committed: https://crrev.com/8dcde7eb270e9e917ebd0ebade754a8351d4db0b
Cr-Commit-Position: refs/heads/master@{#370617}
==========

[commit-bot: I haz the power, 2016-01-21 04:17:49]

Patchset 3 (id:??) landed as
https://crrev.com/8dcde7eb270e9e917ebd0ebade754a8351d4db0b
Cr-Commit-Position: refs/heads/master@{#370617}