Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1608953002: dart2js: Turn the CPS inlining cache into a general compilation cache. (Closed)

Created:
4 years, 11 months ago by Kevin Millikin (Google)
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Turn the CPS inlining cache into a general compilation cache. Cache function definition terms just before specializing them for their arguments. Use these cached terms for subsequent specializations and for generic (non-specialized) compilation. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/cabf28ce8755c29abddaed9b6c2d6976c7c358b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M pkg/compiler/lib/src/cps_ir/inline.dart View 3 chunks +27 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
4 years, 11 months ago (2016-01-19 15:18:08 UTC) #2
asgerf
LGTM
4 years, 11 months ago (2016-01-19 23:55:43 UTC) #3
Kevin Millikin (Google)
4 years, 11 months ago (2016-01-25 11:03:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cabf28ce8755c29abddaed9b6c2d6976c7c358b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698