Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1608933003: MIPS: Use the Lsa() macro/r6 instruction in existing code. (Closed)

Created:
4 years, 11 months ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Use the Lsa() macro/r6 instruction in existing code. BUG= Committed: https://crrev.com/d9af984e701599ae3a3794142847605727befe1f Cr-Commit-Position: refs/heads/master@{#33390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -212 lines) Patch
M src/crankshaft/mips/lithium-codegen-mips.cc View 10 chunks +13 lines, -26 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/builtins-mips.cc View 27 chunks +31 lines, -58 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 36 chunks +39 lines, -78 lines 0 comments Download
M src/mips/codegen-mips.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 8 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
balazs.kilvady
It passed optdebug.check tests on mipsel sim r2 and r6.
4 years, 11 months ago (2016-01-19 14:07:22 UTC) #3
ivica.bogosavljevic
lgtm nice work
4 years, 11 months ago (2016-01-19 15:21:39 UTC) #4
akos.palfi.imgtec
lgtm
4 years, 11 months ago (2016-01-19 15:28:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608933003/1
4 years, 11 months ago (2016-01-19 16:03:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 16:31:35 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 16:32:33 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d9af984e701599ae3a3794142847605727befe1f
Cr-Commit-Position: refs/heads/master@{#33390}

Powered by Google App Engine
This is Rietveld 408576698