Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5719)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Issue 1608843002: Start untangling the avatar switcher from BrowserNonClientFrameView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20160119-MacViewsBrowser-Compile
Patch Set: various selfnits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index 61599daff22785c2f02e076b39ddf56834c00073..c2b38d506ebbe7d11687793842e50d8e85a7b7cb 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -19,7 +19,6 @@
#include "chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h"
#include "chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h"
#include "chrome/browser/ui/views/profiles/avatar_menu_button.h"
-#include "chrome/browser/ui/views/profiles/new_avatar_button.h"
#include "chrome/browser/ui/views/tab_icon_view.h"
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
@@ -320,19 +319,6 @@ void OpaqueBrowserFrameView::ButtonPressed(views::Button* sender,
frame()->Restore();
} else if (sender == close_button_) {
frame()->Close();
-#if defined(FRAME_AVATAR_BUTTON)
- } else if (sender == new_avatar_button()) {
- BrowserWindow::AvatarBubbleMode mode =
- BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT;
- if ((event.IsMouseEvent() &&
- static_cast<const ui::MouseEvent&>(event).IsRightMouseButton()) ||
- (event.type() == ui::ET_GESTURE_LONG_PRESS)) {
- mode = BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH;
- }
- browser_view()->ShowAvatarBubbleFromAvatarButton(
- mode, signin::ManageAccountsParams(),
- signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);
-#endif
}
}
@@ -487,7 +473,7 @@ bool OpaqueBrowserFrameView::ShouldPaintAsThemed() const {
void OpaqueBrowserFrameView::UpdateNewAvatarButtonImpl() {
#if defined(FRAME_AVATAR_BUTTON)
- UpdateNewAvatarButton(this, NewAvatarButton::THEMED_BUTTON);
+ UpdateNewAvatarButton(AVATAR_BUTTON_THEMED);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698