Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1608743006: [wasm] Verify boundaries of data segments when decoding modules. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Verify boundaries of data segments when decoding modules. R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 Committed: https://crrev.com/d48feaccf2f07d1722d0f3508e1efef10c5c6766 Cr-Commit-Position: refs/heads/master@{#33411}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -54 lines) Patch
M src/wasm/module-decoder.cc View 1 2 chunks +25 lines, -6 lines 0 comments Download
M src/wasm/wasm-js.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +1 line, -11 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 2 chunks +1 line, -1 line 0 comments Download
M src/wasm/wasm-opcodes.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 7 chunks +90 lines, -34 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
titzer
4 years, 11 months ago (2016-01-20 14:28:20 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-20 14:46:35 UTC) #2
bradnelson
lgtm https://codereview.chromium.org/1608743006/diff/1/src/wasm/module-decoder.cc File src/wasm/module-decoder.cc (right): https://codereview.chromium.org/1608743006/diff/1/src/wasm/module-decoder.cc#newcode348 src/wasm/module-decoder.cc:348: bool IsWithinLimit(uint32_t limit, uint32_t low, uint32_t size) { ...
4 years, 11 months ago (2016-01-20 14:49:34 UTC) #3
titzer
On 2016/01/20 14:49:34, bradnelson wrote: > lgtm > > https://codereview.chromium.org/1608743006/diff/1/src/wasm/module-decoder.cc > File src/wasm/module-decoder.cc (right): > ...
4 years, 11 months ago (2016-01-20 14:55:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608743006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608743006/20001
4 years, 11 months ago (2016-01-20 14:55:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-20 15:20:04 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 15:20:29 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d48feaccf2f07d1722d0f3508e1efef10c5c6766
Cr-Commit-Position: refs/heads/master@{#33411}

Powered by Google App Engine
This is Rietveld 408576698