Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/bots/compiler.py

Issue 16087002: Don't special case chrome to drt on linux. Instead I will change the name of the bot to dart2js-drt… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 23200)
+++ tools/bots/compiler.py (working copy)
@@ -23,7 +23,7 @@
DART2JS_BUILDER = (
r'dart2js-(linux|mac|windows)(-(jsshell))?-(debug|release)(-(checked|host-checked))?(-(host-checked))?(-(minified))?-?(\d*)-?(\d*)')
WEB_BUILDER = (
- r'dart2js-(ie9|ie10|ff|safari|chrome|chromeOnAndroid|opera)-(win7|win8|mac10\.8|mac10\.7|linux)(-(all|html))?(-(csp))?(-(\d+)-(\d+))?')
+ r'dart2js-(ie9|ie10|ff|safari|chrome|chromeOnAndroid|opera|drt)-(win7|win8|mac10\.8|mac10\.7|linux)(-(all|html))?(-(csp))?(-(\d+)-(\d+))?')
def GetBuildInfo(builder_name, is_buildbot):
@@ -120,10 +120,6 @@
user_test = os.environ.get('USER_TEST', 'no')
- # TODO(ricow): temporary hack to run on fyi with --use_browser_controller
- if os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main" and runtime == 'drt':
- runtime = 'chrome'
-
cmd.extend([sys.executable,
os.path.join(os.curdir, 'tools', 'test.py'),
'--step_name=' + step_name,
@@ -194,10 +190,7 @@
'Local', 'Google', 'Chrome', 'Application', 'chrome.exe')}
return path_dict[runtime]
- if system == 'linux' and runtime == 'chrome':
- # TODO(ngeoffray): We should install selenium on the buildbot.
- runtime = 'drt'
- elif (runtime == 'ff' or runtime == 'chrome') and is_buildbot:
+ if (runtime == 'ff' or runtime == 'chrome') and is_buildbot:
# Print out browser version numbers if we're running on the buildbot (where
# we know the paths to these browser installations).
version_query_string = '"%s" --version' % GetPath(runtime)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698