Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 1608693004: [interpreter] Simplify ConstantArrayBuilder interface a bit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_int-2
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/interpreter/constant-array-builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-array-builder.cc
diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc
index d0fb1d5664509ee205bb42dd89d013c10ba5ed18..91cfe4df8fa4730c86caa3a5cd7bb958d839ad02 100644
--- a/src/interpreter/bytecode-array-builder.cc
+++ b/src/interpreter/bytecode-array-builder.cc
@@ -150,13 +150,11 @@ Handle<BytecodeArray> BytecodeArrayBuilder::ToBytecodeArray() {
int bytecode_size = static_cast<int>(bytecodes_.size());
int register_count = fixed_register_count() + temporary_register_count_;
int frame_size = register_count * kPointerSize;
- Factory* factory = isolate_->factory();
- Handle<FixedArray> constant_pool =
- constant_array_builder()->ToFixedArray(factory);
+ Handle<FixedArray> constant_pool = constant_array_builder()->ToFixedArray();
Handle<FixedArray> handler_table = handler_table_builder()->ToHandlerTable();
- Handle<BytecodeArray> output =
- factory->NewBytecodeArray(bytecode_size, &bytecodes_.front(), frame_size,
- parameter_count(), constant_pool);
+ Handle<BytecodeArray> output = isolate_->factory()->NewBytecodeArray(
+ bytecode_size, &bytecodes_.front(), frame_size, parameter_count(),
+ constant_pool);
output->set_handler_table(*handler_table);
Michael Starzinger 2016/01/19 16:38:55 I could make the handler table and argument to the
bytecode_generated_ = true;
return output;
« no previous file with comments | « no previous file | src/interpreter/constant-array-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698