Issue 1608593003: Fix an assertion failure in CXFA_FWLTheme::Initialize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1608593003: Fix an assertion failure in CXFA_FWLTheme::Initialize() (Closed)

Created:
4 years, 11 months ago by jun_fang

Modified:
4 years, 11 months ago

Reviewers:
Tom Sepez, Lei Zhang, Jim Wang

CC:
pdfium-reviews_googlegroups.com, kai_jing, xiaoxia_yu_foxitsoftware.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -39 lines)			Patch
M	core/include/fxge/fx_font.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	xfa/src/fgas/src/font/fx_stdfontmgr.h	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	xfa/src/fgas/src/font/fx_stdfontmgr.cpp	View	8 chunks	+108 lines, -38 lines	0 comments	Download

Total messages: 5 (2 generated)

jun_fang

Hi Tom and Lei, Please review this CL. I was considering to create a test ...

4 years, 11 months ago (2016-01-19 11:23:53 UTC) #2

jun_fang

4 years, 11 months ago (2016-01-20 01:14:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
fe73e7849b8b4ce49408d2f52f3fc29b370b82b5 (presubmit successful).