src/arm64/code-stubs-arm64.cc - Issue 1608583002: New page local store buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/code-stubs-arm64.cc

Issue 1608583002: New page local store buffer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Revert dynamic buckets Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/code-stubs-arm64.cc

diff --git a/src/arm64/code-stubs-arm64.cc b/src/arm64/code-stubs-arm64.cc

index 3ead0757a585a456253436848ef3ac9d785725e3..041ddfeb1bfecb13c65593dd03c996c680d7e105 100644

--- a/src/arm64/code-stubs-arm64.cc

+++ b/src/arm64/code-stubs-arm64.cc

@@ -4095,8 +4095,7 @@ void RecordWriteStub::GenerateIncremental(MacroAssembler* masm, Mode mode) {

__ Ldr(val, MemOperand(regs_.address()));

__ JumpIfNotInNewSpace(val, &dont_need_remembered_set);

- __ CheckPageFlagSet(regs_.object(), val, 1 << MemoryChunk::SCAN_ON_SCAVENGE,

- &dont_need_remembered_set);

+ __ JumpIfInNewSpace(regs_.object(), &dont_need_remembered_set);

// First notify the incremental marker if necessary, then update the

// remembered set.