Allowing component extensions to request permissions NOT only from user's gestures

chrome/browser/extensions/api/permissions/permissions_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/permissions/permissions_api.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/api/permissions/permissions_api_helpers.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/permissions_updater.h"
@@ skipping 129 matching lines @@
   SendResponse(true);
 
   Release();  // Balanced in RunImpl().
 }
 
 PermissionsRequestFunction::~PermissionsRequestFunction() {}
 
 bool PermissionsRequestFunction::RunImpl() {
   results_ = Request::Results::Create(false);
 
-  if (!user_gesture() && !ignore_user_gesture_for_tests) {
+  if (!user_gesture() &&
+      !ignore_user_gesture_for_tests &&
+      extension_->location() != Manifest::COMPONENT) {
     error_ = kUserGestureRequiredError;
     return false;
   }
 
   scoped_ptr<Request::Params> params(Request::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   requested_permissions_ =
       helpers::UnpackPermissionSet(
           params->permissions,
@@ skipping 41 matching lines @@
 
   // Filter out the granted permissions so we only prompt for new ones.
   requested_permissions_ = PermissionSet::CreateDifference(
       requested_permissions_.get(), granted.get());
 
   AddRef();  // Balanced in InstallUIProceed() / InstallUIAbort().
 
   // We don't need to show the prompt if there are no new warnings, or if
   // we're skipping the confirmation UI. All extension types but INTERNAL
   // are allowed to silently increase their permission level.
-  bool has_no_warnings = requested_permissions_->GetWarningMessages(
-      GetExtension()->GetType()).empty();
+  bool has_no_warnings = extension_->location() == Manifest::COMPONENT ||

[Matt Perry, 2013/06/05 00:26:52]

nit: this really belongs on the if statement below.

[vadimt, 2013/06/05 00:33:07]

Done.

+      requested_permissions_->GetWarningMessages(
+          GetExtension()->GetType()).empty();
   if (auto_confirm_for_tests == PROCEED || has_no_warnings) {
     InstallUIProceed();
   } else if (auto_confirm_for_tests == ABORT) {
     // Pretend the user clicked cancel.
     InstallUIAbort(true);
   } else {
     CHECK_EQ(DO_NOT_SKIP, auto_confirm_for_tests);
     install_ui_.reset(new ExtensionInstallPrompt(GetAssociatedWebContents()));
     install_ui_->ConfirmPermissions(
         this, GetExtension(), requested_permissions_.get());
   }
 
   return true;
 }
 
 }  // namespace extensions