Issue 1608483004: dart2js: Flatten the code generation visitor a little bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1608483004: dart2js: Flatten the code generation visitor a little bit. (Closed)

Created:
4 years, 11 months ago by Kevin Millikin (Google)

Modified:
4 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Flatten the code generation visitor a little bit. Do not call visitStatement in tail position, do not call List.generate (which calls its argument). BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b1c627be709b37f43d8461e8dc6332751f5800b3

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -18 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View		11 chunks	+29 lines, -18 lines	0 comments	Download

Total messages: 5 (2 generated)

Kevin Millikin (Google)

On 2016/01/19 16:44:40, Siggi Cherem (dart-lang) wrote: > lgtm I wasn't sure how to easily ...

4 years, 11 months ago (2016-01-19 16:48:34 UTC) #3

Kevin Millikin (Google)

4 years, 11 months ago (2016-01-25 11:01:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b1c627be709b37f43d8461e8dc6332751f5800b3 (presubmit successful).