Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 160843003: Fix getField/setField optimization for private members. (Closed)

Created:
6 years, 10 months ago by rmacnak
Modified:
6 years, 10 months ago
Reviewers:
hausner, kasperl
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix getField/setField optimization for private members. BUG=http://dartbug.com/16773 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=32634

Patch Set 1 #

Patch Set 2 : dart2js status, negative test #

Total comments: 2

Patch Set 3 : dart style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1 line) Patch
M runtime/lib/mirrors.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
A tests/lib/mirrors/hot_get_field_test.dart View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A tests/lib/mirrors/hot_set_field_test.dart View 1 2 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
6 years, 10 months ago (2014-02-12 21:47:22 UTC) #1
hausner
LGTM w/comment. https://codereview.chromium.org/160843003/diff/30001/tests/lib/mirrors/hot_get_field_test.dart File tests/lib/mirrors/hot_get_field_test.dart (right): https://codereview.chromium.org/160843003/diff/30001/tests/lib/mirrors/hot_get_field_test.dart#newcode21 tests/lib/mirrors/hot_get_field_test.dart:21: for (int i = 0; i < ...
6 years, 10 months ago (2014-02-12 23:35:42 UTC) #2
rmacnak
https://chromiumcodereview.appspot.com/160843003/diff/30001/tests/lib/mirrors/hot_get_field_test.dart File tests/lib/mirrors/hot_get_field_test.dart (right): https://chromiumcodereview.appspot.com/160843003/diff/30001/tests/lib/mirrors/hot_get_field_test.dart#newcode21 tests/lib/mirrors/hot_get_field_test.dart:21: for (int i = 0; i < 2*optimizationThreshold; i++) ...
6 years, 10 months ago (2014-02-12 23:44:12 UTC) #3
rmacnak
Committed patchset #3 manually as r32634 (presubmit successful).
6 years, 10 months ago (2014-02-12 23:44:43 UTC) #4
kasperl
Is this something that should be merged to trunk? Please go ahead an file a ...
6 years, 10 months ago (2014-02-13 12:57:29 UTC) #5
rmacnak
6 years, 10 months ago (2014-02-13 18:50:49 UTC) #6
Message was sent while issue was closed.
On 2014/02/13 12:57:29, kasperl wrote:
> Is this something that should be merged to trunk? Please go ahead an file a
> merge request if so.

Merged in r32664

Powered by Google App Engine
This is Rietveld 408576698