Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1608373002: VS 2015 package with VSINSTALLDIR and VCINSTALLDIR (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 11 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VS 2015 package with VSINSTALLDIR and VCINSTALLDIR This is a rebuild of the VS 2015 package that incorporates the changes made in crrev.com/1604423002 BUG=82385 Committed: https://crrev.com/9b7851a6d4410fa5aecb3a8c13cae8c709f9d2ee Cr-Commit-Position: refs/heads/master@{#370586}

Patch Set 1 #

Patch Set 2 : VS 2015 update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
brucedawson
I built this package on the same VM as the previous VS 2015 package, and ...
4 years, 11 months ago (2016-01-20 23:42:54 UTC) #4
scottmg
lgtm
4 years, 11 months ago (2016-01-20 23:46:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608373002/20001
4 years, 11 months ago (2016-01-21 00:34:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 02:43:17 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 02:43:57 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b7851a6d4410fa5aecb3a8c13cae8c709f9d2ee
Cr-Commit-Position: refs/heads/master@{#370586}

Powered by Google App Engine
This is Rietveld 408576698