resolution dependent path measure

resolution dependent path measure

When a dash is drawn through a canvas with a scaled up
matrix, path measure needs the pixel resolution through
the matrix to construct the dash with sufficient
resolution.

Pass the resolution through to path measure.

Replicate chrome bug in skia GM.

R=reed@google.com
BUG=530095
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1608353002

Committed: https://skia.googlesource.com/skia/+/1a7eb266644d2e1b0968dbca606ca0a91903419d

[caryclark, 2016-01-20 20:45:51]

Description was changed from

==========
scaled dashed path bug

replicate chrome bug in skia

TBR=reed@google.com
BUG=530095
==========

to

==========
scaled dashed path bug

replicate chrome bug in skia

TBR=reed@google.com
BUG=530095
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[caryclark, 2016-01-20 21:32:59]

Description was changed from

==========
scaled dashed path bug

replicate chrome bug in skia

TBR=reed@google.com
BUG=530095
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
resolution dependent path measure

When a dash is drawn through a canvas with a scaled up
matrix, path measure needs the pixel resolution through
the matrix to construct the dash with sufficient
resolution.

Pass the resolution through to path measure.

Replicate chrome bug in skia GM.

R=reed@google.com
BUG=530095
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[caryclark, 2016-01-20 21:41:21]

Verified that this fixes the GM that is part of this CL.
The chrome define to suppress this is in flight.

[caryclark, 2016-01-20 21:41:26]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 21:41:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608353002/20001

[commit-bot: I haz the power, 2016-01-20 21:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 21:55:46]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-01-20 22:17:52]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 22:17:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608353002/40001

[commit-bot: I haz the power, 2016-01-20 22:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 22:29:19]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-01-21 12:31:56]

Chrome ignore legacy flag has landed.
Gold trybot results show bug is fixed.

[reed1, 2016-01-21 14:33:59]

https://codereview.chromium.org/1608353002/diff/40001/include/core/SkPathMeas...
File include/core/SkPathMeasure.h (right):

https://codereview.chromium.org/1608353002/diff/40001/include/core/SkPathMeas...
include/core/SkPathMeasure.h:24: SkPathMeasure(const SkPath& path, bool
forceClosed, SkScalar resScale = 1);
// resScale controls the precision of the measure. values > 1 increase the
precision (and possible slow down the computation).

https://codereview.chromium.org/1608353002/diff/40001/include/core/SkPathMeas...
include/core/SkPathMeasure.h:85: SkScalar        fInvResScale;
nit: rename to fTolerance?

[caryclark, 2016-01-21 14:52:57]

https://codereview.chromium.org/1608353002/diff/40001/include/core/SkPathMeas...
File include/core/SkPathMeasure.h (right):

https://codereview.chromium.org/1608353002/diff/40001/include/core/SkPathMeas...
include/core/SkPathMeasure.h:24: SkPathMeasure(const SkPath& path, bool
forceClosed, SkScalar resScale = 1);
On 2016/01/21 14:33:59, reed1 wrote:
> // resScale controls the precision of the measure. values > 1 increase the
> precision (and possible slow down the computation).

Done.

https://codereview.chromium.org/1608353002/diff/40001/include/core/SkPathMeas...
include/core/SkPathMeasure.h:85: SkScalar        fInvResScale;
On 2016/01/21 14:33:59, reed1 wrote:
> nit: rename to fTolerance?

Done.

[reed1, 2016-01-21 14:53:51]

lgtm

[caryclark, 2016-01-21 14:55:16]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-01-21 14:55:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608353002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608353002/80001

[commit-bot: I haz the power, 2016-01-21 15:07:04]

Description was changed from

==========
resolution dependent path measure

When a dash is drawn through a canvas with a scaled up
matrix, path measure needs the pixel resolution through
the matrix to construct the dash with sufficient
resolution.

Pass the resolution through to path measure.

Replicate chrome bug in skia GM.

R=reed@google.com
BUG=530095
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
resolution dependent path measure

When a dash is drawn through a canvas with a scaled up
matrix, path measure needs the pixel resolution through
the matrix to construct the dash with sufficient
resolution.

Pass the resolution through to path measure.

Replicate chrome bug in skia GM.

R=reed@google.com
BUG=530095
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1a7eb266644d2e1b0968dbca606ca0a91903419d
==========

[commit-bot: I haz the power, 2016-01-21 15:07:05]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/1a7eb266644d2e1b0968dbca606ca0a91903419d