BUILD.gn - Issue 1608343002: Configure icu to copy icudtl.dat into the application bundle on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1608343002: Configure icu to copy icudtl.dat into the application bundle on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master

Patch Set: Sync with GN tool changes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 77f8aa6a06e90fc4df8f4126f0bb96e2ee33f2bb..e743593a25e791edf65bfac6ef6a8804ed17c8a2 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -539,9 +539,9 @@ if (is_android) {

if (icu_use_data_file) {

if (is_ios) {

group("icudata") {

- # TODO(GYP): Provide an empty group so that this target does not

- # unconditionally fail. The dat file needs to be bundled separately. In

- # the longer term, need to figure out how to use system ICU

+ bundle_data = [

+ "source/data/in/icudtl.dat",

+ ]

}

} else {

copy("icudata") {

« no previous file with comments | « no previous file | no next file » | no next file with comments »