Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: pydir/szbuild.py

Issue 1608323002: Subzero: Change the szbuild.py --force default. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix makefile Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile.standalone ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/szbuild.py
diff --git a/pydir/szbuild.py b/pydir/szbuild.py
index 5f645b86e03aec9b1129f2fcf4194f495ebce0f4..36112dad2fdf9e50b78c2008d21a11ae88e0aeb6 100755
--- a/pydir/szbuild.py
+++ b/pydir/szbuild.py
@@ -61,8 +61,10 @@ def MatchSymbol(sym, re_include, re_exclude, default_match):
return default_match
def AddOptionalArgs(argparser):
- argparser.add_argument('--force', dest='force', action='store_true',
- help='Force all re-translations of the pexe')
+ argparser.add_argument('--force', dest='force', type=int, choices=[0, 1],
+ default=1,
+ help='Force all re-translations of the pexe.' +
+ ' Default %(default)s.')
argparser.add_argument('--include', '-i', default=[], dest='include',
action='append',
help='Subzero symbols to include ' +
@@ -240,11 +242,11 @@ def main():
If no --include or --exclude arguments are given, the executable is produced
entirely using Subzero, without using llc or linker tricks.
- This script uses file modification timestamps to determine whether llc and
- Subzero re-translation are needed. It checks timestamps of llc, pnacl-sz,
- and the pexe against the translated object files to determine the minimal
- work necessary. The --force option suppresses those checks and
- re-translates everything.
+ When using the --force=0 option, this script uses file modification
+ timestamps to determine whether llc and Subzero re-translation are needed.
+ It checks timestamps of llc, pnacl-sz, and the pexe against the translated
+ object files to determine the minimal work necessary. The --force=1 option
+ (default) suppresses those checks and re-translates everything.
This script expects various PNaCl and LLVM tools to be found within the
native_client tree. When changes are made to these tools, copy them this
« no previous file with comments | « Makefile.standalone ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698