Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1608323002: Subzero: Change the szbuild.py --force default. (Closed)

Created:
4 years, 11 months ago by Jim Stichnoth
Modified:
4 years, 11 months ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Change the szbuild.py --force default. With the --force option, the behavior of its default setting is dangerous. Specifically, it doesn't retranslate by default when you change the szbuild command-line arguments. This leads to debugging frustration. Therefore, we change the default setting to be "dumb" and always retranslate. For bisection debugging, the user will quickly realize that they want to add "--force=0". BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bc3bd502de1a60b91cc95157e2d9f530e022180f

Patch Set 1 #

Patch Set 2 : Fix makefile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M Makefile.standalone View 1 1 chunk +1 line, -1 line 0 comments Download
M pydir/szbuild.py View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 11 months ago (2016-01-20 20:05:44 UTC) #3
John
lgtm
4 years, 11 months ago (2016-01-20 20:11:42 UTC) #4
Jim Stichnoth
4 years, 11 months ago (2016-01-20 23:01:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bc3bd502de1a60b91cc95157e2d9f530e022180f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698