Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: components/nacl/renderer/plugin/pnacl_coordinator.h

Issue 1608313002: PNaCl cleanup: Simplify error checking when opening temp files (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Review: remove arg & move check Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/nacl/renderer/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/plugin/pnacl_coordinator.h
diff --git a/components/nacl/renderer/plugin/pnacl_coordinator.h b/components/nacl/renderer/plugin/pnacl_coordinator.h
index b409c241174eaede42cadd15f08542d2085450c2..5b9638ddda760e60cbb7b94cbdfd55750c4ab419 100644
--- a/components/nacl/renderer/plugin/pnacl_coordinator.h
+++ b/components/nacl/renderer/plugin/pnacl_coordinator.h
@@ -111,7 +111,7 @@ class PnaclCoordinator {
void TranslateFinished(int32_t pp_error);
// Invoked when the read descriptor for nexe_file_ is created.
- void NexeReadDidOpen(int32_t pp_error);
+ void NexeReadDidOpen();
// Bring control back to the plugin by invoking the
// |translate_notify_callback_|. This does not set the ErrorInfo report,
@@ -120,12 +120,6 @@ class PnaclCoordinator {
// Run |translate_notify_callback_| with an error condition that is not
// PPAPI specific. Also set ErrorInfo report.
void ReportNonPpapiError(PP_NaClError err, const std::string& message);
- // Run when faced with a PPAPI error condition. Bring control back to the
- // plugin by invoking the |translate_notify_callback_|.
- // Also set ErrorInfo report.
- void ReportPpapiError(PP_NaClError err,
- int32_t pp_error, const std::string& message);
-
// Keeps track of the pp_error upon entry to TranslateFinished,
// for inspection after cleanup.
« no previous file with comments | « no previous file | components/nacl/renderer/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698