components/nacl/renderer/plugin/temporary_file.h - Issue 1608313002: PNaCl cleanup: Simplify error checking when opening temp files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/renderer/plugin/temporary_file.h

Issue 1608313002: PNaCl cleanup: Simplify error checking when opening temp files (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/renderer/plugin/pnacl_coordinator.cc ('K') | « components/nacl/renderer/plugin/pnacl_coordinator.cc ('k') | components/nacl/renderer/plugin/temporary_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/renderer/plugin/temporary_file.h

diff --git a/components/nacl/renderer/plugin/temporary_file.h b/components/nacl/renderer/plugin/temporary_file.h

index fe496f4daa6f8f028ef64b2ba85f4598a69337af..f0669c0a4a096591648a111ef90223e4d2d72326 100644

--- a/components/nacl/renderer/plugin/temporary_file.h

+++ b/components/nacl/renderer/plugin/temporary_file.h

@@ -42,7 +42,7 @@ class TempFile {

TempFile(Plugin* plugin, PP_FileHandle handle);

~TempFile();

- int32_t CheckValidity();

+ bool IsValid() { return file_handle_.IsValid(); }

// Resets file position of the handle, for reuse.

bool Reset();