PNaCl cleanup: Simplify error checking when opening temp files

components/nacl/renderer/plugin/pnacl_coordinator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_RENDERER_PLUGIN_PNACL_COORDINATOR_H_
 #define COMPONENTS_NACL_RENDERER_PLUGIN_PNACL_COORDINATOR_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 93 matching lines @@
   // subprocesses, one for llc and one for ld.
   void LoadCompiler();
   void RunCompile(int32_t pp_error, int64_t compile_load_start_time);
   void LoadLinker(int32_t pp_error);
   void RunLink(int32_t pp_error, int64_t ld_load_start_time);
 
   // Invoked when translation is finished.
   void TranslateFinished(int32_t pp_error);
 
   // Invoked when the read descriptor for nexe_file_ is created.
-  void NexeReadDidOpen(int32_t pp_error);
+  void NexeReadDidOpen(bool success);
 
   // Bring control back to the plugin by invoking the
   // |translate_notify_callback_|.  This does not set the ErrorInfo report,
   // it is assumed that it was already set.
   void ExitWithError();
   // Run |translate_notify_callback_| with an error condition that is not
   // PPAPI specific.  Also set ErrorInfo report.
   void ReportNonPpapiError(PP_NaClError err, const std::string& message);
-  // Run when faced with a PPAPI error condition. Bring control back to the
-  // plugin by invoking the |translate_notify_callback_|.
-  // Also set ErrorInfo report.
-  void ReportPpapiError(PP_NaClError err,
-                        int32_t pp_error, const std::string& message);
-
 
   // Keeps track of the pp_error upon entry to TranslateFinished,
   // for inspection after cleanup.
   int32_t translate_finish_error_;
 
   // The plugin owning the nexe for which we are doing translation.
   Plugin* plugin_;
 
   pp::CompletionCallback translate_notify_callback_;
   // Set to true when the translation (if applicable) is finished and the nexe
@@ skipping 47 matching lines @@
   // shorter lifetime.
   scoped_ptr<PnaclTranslateThread> translate_thread_;
 
   DISALLOW_COPY_AND_ASSIGN(PnaclCoordinator);
 };
 
 //----------------------------------------------------------------------
 
 }  // namespace plugin;
 #endif  // COMPONENTS_NACL_RENDERER_PLUGIN_PNACL_COORDINATOR_H_