Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1608303002: Removed OLD_SYNC_POINT sync token namespace. (Closed)

Created:
4 years, 11 months ago by David Yen
Modified:
4 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed OLD_SYNC_POINT sync token namespace. R=piman@chromium.org BUG=514815 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/398dd0147b06be59474bf28fa06bf675f0d79908 Cr-Commit-Position: refs/heads/master@{#370799}

Patch Set 1 #

Patch Set 2 : Fixed some more unit tests #

Patch Set 3 : rebase #

Patch Set 4 : Fix CCMessagesTest.Resources #

Patch Set 5 : Fixed cc_perftests, formatted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -53 lines) Patch
M cc/layers/texture_layer_unittest.cc View 12 chunks +28 lines, -16 lines 0 comments Download
M cc/output/delegating_renderer_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/test/render_pass_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/render_pass_test_utils.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 1 2 3 4 3 chunks +9 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/cc_messages_unittest.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/sync_token.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
David Yen
4 years, 11 months ago (2016-01-20 19:17:13 UTC) #1
piman
lgtm
4 years, 11 months ago (2016-01-20 20:46:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608303002/70011 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608303002/70011
4 years, 11 months ago (2016-01-21 19:44:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/168440)
4 years, 11 months ago (2016-01-21 20:30:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608303002/70011 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608303002/70011
4 years, 11 months ago (2016-01-21 21:17:17 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:70011)
4 years, 11 months ago (2016-01-21 22:06:03 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 22:08:37 UTC) #13
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/398dd0147b06be59474bf28fa06bf675f0d79908
Cr-Commit-Position: refs/heads/master@{#370799}

Powered by Google App Engine
This is Rietveld 408576698