Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1608283002: PlzNavigate: Use WebNavigationPolicyHandledByClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@change-did-start-loading-logic
Patch Set: Addressed comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 1deec21173d6c6358a6a0b31b8ec4d51a9468a2a..3e63503911f661bd5783de54f38d42e130dbfac7 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4668,7 +4668,11 @@ void RenderFrameImpl::didStartLoading(bool to_different_document) {
TRACE_EVENT1("navigation", "RenderFrameImpl::didStartLoading",
"id", routing_id_);
render_view_->FrameDidStartLoading(frame_);
- Send(new FrameHostMsg_DidStartLoading(routing_id_, to_different_document));
+
+ // PlzNavigate: the browser is responsible for knowing the start of all
+ // non-synchronous navigations.
+ if (!IsBrowserSideNavigationEnabled() || !to_different_document)
+ Send(new FrameHostMsg_DidStartLoading(routing_id_, to_different_document));
}
void RenderFrameImpl::didStopLoading() {
@@ -4964,7 +4968,7 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
ShouldMakeNetworkRequestForURL(url)) {
BeginNavigation(&info.urlRequest, info.replacesCurrentHistoryItem,
info.isClientRedirect);
- return blink::WebNavigationPolicyIgnore;
+ return blink::WebNavigationPolicyHandledByClient;
}
return info.defaultPolicy;

Powered by Google App Engine
This is Rietveld 408576698