Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1608263003: Revert of [PNaCl toolchain] Stop building and using custom libc++ for OSX hosts (Closed)

Created:
4 years, 11 months ago by Derek Schuff
Modified:
4 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert of [PNaCl toolchain] Stop building and using custom libc++ for OSX hosts (patchset #2 id:20001 of https://codereview.chromium.org/1572753002/ ) Reason for revert: This patch (as-is) causes a dependency on the system libc++ which breaks the toolchain on OSX. I have a better (for the short term) fix for this. Original issue's description: > [PNaCl toolchain] Stop building and using custom libc++ for OSX hosts > > Our Mac buildbots recently started using a different SDK, and our local build > of libc++ doesn't work with that SDK. Instead of fixing it, we can just > use the libc++ that recently started shipping with the clang we use to > build the toolchain (and Chrome). > So on Mac hosts, continue using the -stdlib=libc++ flag, but do not build, > use, or upload our local libc++. > > R=mcgrathr@chromium.org, stichnot@chromium.org > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/a1f591d21f3989e78f7805d7d2d92e6fb3a3f2a4 TBR=mcgrathr@chromium.org,stichnot@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://chromium.googlesource.com/native_client/src/native_client/+/a52204c9b2b32f5cef75ffa43242b914b2706924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M toolchain_build/toolchain_build_pnacl.py View 5 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Derek Schuff
Created Revert of [PNaCl toolchain] Stop building and using custom libc++ for OSX hosts
4 years, 11 months ago (2016-01-20 17:44:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608263003/1
4 years, 11 months ago (2016-01-20 17:44:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608263003/1
4 years, 11 months ago (2016-01-20 17:50:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/native_client/src/native_client/+/a52204c9b2b32f5cef75ffa43242b914b2706924
4 years, 11 months ago (2016-01-20 17:51:36 UTC) #8
Jim Stichnoth
4 years, 11 months ago (2016-01-20 18:21:35 UTC) #9
Message was sent while issue was closed.
LGTM.  The trybots look awesome! :)

Powered by Google App Engine
This is Rietveld 408576698