Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1608223002: Rename |emitCharacter| to |spliceBuffer| (Closed)

Created:
4 years, 11 months ago by ramya.v
Modified:
4 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename |emitCharacter| to |spliceBuffer| Rename |emitCharacter| to |spliceBuffer| as it does both inserting and removing characters. BUG=None Committed: https://crrev.com/b433e60a0ea68dacf2db7d8cf40012c8feb8f4f2 Cr-Commit-Position: refs/heads/master@{#370636}

Patch Set 1 #

Patch Set 2 : Rebasing the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M third_party/WebKit/Source/core/editing/iterators/TextIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 11 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ramya.v
PTAL! Thanks
4 years, 11 months ago (2016-01-21 04:29:30 UTC) #2
yosin_UTC9
lgtm Thanks for quick work!
4 years, 11 months ago (2016-01-21 04:56:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608223002/20001
4 years, 11 months ago (2016-01-21 04:56:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 06:18:15 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 06:18:59 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b433e60a0ea68dacf2db7d8cf40012c8feb8f4f2
Cr-Commit-Position: refs/heads/master@{#370636}

Powered by Google App Engine
This is Rietveld 408576698