Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: src/arm/lithium-arm.h

Issue 16082008: Increase sanity of integer division handling on ARM (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed Rodolph's comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 LOperand* right() { return inputs_[1]; } 604 LOperand* right() { return inputs_[1]; }
605 LOperand* temp() { return temps_[0]; } 605 LOperand* temp() { return temps_[0]; }
606 LOperand* temp2() { return temps_[1]; } 606 LOperand* temp2() { return temps_[1]; }
607 LOperand* temp3() { return temps_[2]; } 607 LOperand* temp3() { return temps_[2]; }
608 608
609 DECLARE_CONCRETE_INSTRUCTION(ModI, "mod-i") 609 DECLARE_CONCRETE_INSTRUCTION(ModI, "mod-i")
610 DECLARE_HYDROGEN_ACCESSOR(Mod) 610 DECLARE_HYDROGEN_ACCESSOR(Mod)
611 }; 611 };
612 612
613 613
614 class LDivI: public LTemplateInstruction<1, 2, 0> { 614 class LDivI: public LTemplateInstruction<1, 2, 1> {
615 public: 615 public:
616 LDivI(LOperand* left, LOperand* right) { 616 LDivI(LOperand* left, LOperand* right, LOperand* temp) {
617 inputs_[0] = left; 617 inputs_[0] = left;
618 inputs_[1] = right; 618 inputs_[1] = right;
619 temps_[0] = temp;
619 } 620 }
620 621
621 LOperand* left() { return inputs_[0]; } 622 LOperand* left() { return inputs_[0]; }
622 LOperand* right() { return inputs_[1]; } 623 LOperand* right() { return inputs_[1]; }
624 LOperand* temp() { return temps_[0]; }
623 625
624 DECLARE_CONCRETE_INSTRUCTION(DivI, "div-i") 626 DECLARE_CONCRETE_INSTRUCTION(DivI, "div-i")
625 DECLARE_HYDROGEN_ACCESSOR(Div) 627 DECLARE_HYDROGEN_ACCESSOR(Div)
626 }; 628 };
627 629
628 630
629 class LMathFloorOfDiv: public LTemplateInstruction<1, 2, 1> { 631 class LMathFloorOfDiv: public LTemplateInstruction<1, 2, 1> {
630 public: 632 public:
631 LMathFloorOfDiv(LOperand* left, 633 LMathFloorOfDiv(LOperand* left,
632 LOperand* right, 634 LOperand* right,
(...skipping 2212 matching lines...) Expand 10 before | Expand all | Expand 10 after
2845 2847
2846 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2848 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2847 }; 2849 };
2848 2850
2849 #undef DECLARE_HYDROGEN_ACCESSOR 2851 #undef DECLARE_HYDROGEN_ACCESSOR
2850 #undef DECLARE_CONCRETE_INSTRUCTION 2852 #undef DECLARE_CONCRETE_INSTRUCTION
2851 2853
2852 } } // namespace v8::internal 2854 } } // namespace v8::internal
2853 2855
2854 #endif // V8_ARM_LITHIUM_ARM_H_ 2856 #endif // V8_ARM_LITHIUM_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698