ui/file_manager/gallery/js/slide_mode.js - Issue 1608143002: support animated GIF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/gallery/js/slide_mode.js

Issue 1608143002: support animated GIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add assert to pass closure compiler Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/gallery/js/slide_mode.js

diff --git a/ui/file_manager/gallery/js/slide_mode.js b/ui/file_manager/gallery/js/slide_mode.js

index f2ed0206f5e928b17cd7619ab707beb4613be9b3..a550d201a91c9d1e8fe7717b7eca3cc60db54a11 100644

--- a/ui/file_manager/gallery/js/slide_mode.js

+++ b/ui/file_manager/gallery/js/slide_mode.js

@@ -1041,9 +1041,9 @@ SlideMode.prototype.itemLoaded_ = function(

toMillions(metadata.size));

}

- var canvas = this.imageView_.getCanvas();

+ var image = this.imageView_.getImage();

ImageUtil.metrics.recordSmallCount(ImageUtil.getMetricName('Size.MPix'),

- toMillions(canvas.width * canvas.height));

+ toMillions(image.width * image.height));

var extIndex = entry.name.lastIndexOf('.');

var ext = extIndex < 0 ? '' :

@@ -1299,7 +1299,7 @@ SlideMode.prototype.saveCurrentImage_ = function(item, callback) {

var savedPromise = this.dataModel_.saveItem(

this.volumeManager_,

item,

- this.imageView_.getCanvas(),

+ ImageUtil.ensureCanvas(this.imageView_.getImage()),

this.overwriteOriginalCheckbox_.checked);

savedPromise.then(function() {