Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: ui/file_manager/integration_tests/gallery/open_image_files.js

Issue 1608143002: support animated GIF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix a regression bug that the original image is not removed then the filter applied. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/integration_tests/gallery/open_image_files.js
diff --git a/ui/file_manager/integration_tests/gallery/open_image_files.js b/ui/file_manager/integration_tests/gallery/open_image_files.js
index 49d37f6c3ca73bd39c5c7cc96539ad942bf53bb6..3833c73ae56b0582865ac62fa9903f3e3263aaa5 100644
--- a/ui/file_manager/integration_tests/gallery/open_image_files.js
+++ b/ui/file_manager/integration_tests/gallery/open_image_files.js
@@ -43,16 +43,12 @@ function openSingleImage(testVolumeName, volumeType) {
return resizedWindowPromise.then(function() {
var rootElementPromise =
gallery.waitForElement(appId, '.gallery[mode="slide"]');
- var imagePromise = gallery.waitForElement(
- appId, '.gallery .content canvas.image[width="760"]');
var fullImagePromsie = gallery.waitForElement(
- appId, '.gallery .content canvas.fullres[width="800"]');
- return Promise.all([rootElementPromise, imagePromise, fullImagePromsie]).
+ appId, '.gallery .image-container > .image');
+ return Promise.all([rootElementPromise, fullImagePromsie]).
then(function(args) {
- chrome.test.assertEq('760', args[1].attributes.width);
- chrome.test.assertEq('570', args[1].attributes.height);
- chrome.test.assertEq('800', args[2].attributes.width);
- chrome.test.assertEq('600', args[2].attributes.height);
+ chrome.test.assertEq(760, args[1].renderedWidth);
+ chrome.test.assertEq(570, args[1].renderedHeight);
hirono 2016/01/22 07:24:18 Could you add assertions for imageWidth/imageHeigh
ryoh 2016/01/25 03:29:26 Done.
});
});
});

Powered by Google App Engine
This is Rietveld 408576698