Chromium Code Reviews| Index: ui/file_manager/file_manager/background/js/test_util_base.js |
| diff --git a/ui/file_manager/file_manager/background/js/test_util_base.js b/ui/file_manager/file_manager/background/js/test_util_base.js |
| index 772e48d5f0334ad310c095d863cf89e3ec1e5f8e..372f6359bc8ebe359c00bda3666b8bcf828355f8 100644 |
| --- a/ui/file_manager/file_manager/background/js/test_util_base.js |
| +++ b/ui/file_manager/file_manager/background/js/test_util_base.js |
| @@ -31,6 +31,7 @@ function extractElementInfo(element, contentWindow, opt_styleNames) { |
| styles[styleNames[i]] = computedStyles[styleNames[i]]; |
| } |
| var text = element.textContent; |
| + var size = element.getBoundingClientRect(); |
| return { |
| attributes: attributes, |
| text: text, |
| @@ -38,7 +39,11 @@ function extractElementInfo(element, contentWindow, opt_styleNames) { |
| styles: styles, |
| // The hidden attribute is not in the element.attributes even if |
| // element.hasAttribute('hidden') is true. |
| - hidden: !!element.hidden |
| + hidden: !!element.hidden, |
| + width: Number(element.width), |
|
yawano
2016/01/22 05:03:12
Why don't you simply use renderedWidth? I don't th
ryoh
2016/01/22 05:20:49
It's needed to check both "size":
- "width/height
yawano
2016/01/22 05:52:04
I get it. Thank you!
nit: many of other elements
ryoh
2016/01/22 06:46:03
Done.
yawano
2016/01/22 07:02:49
nit: 0 will be set even if the element doesn't hav
|
| + height: Number(element.height), |
| + renderedWidth: size.width, |
| + renderedHeight: size.height |
| }; |
| } |