support animated GIF

ui/file_manager/file_manager/background/js/test_util_base.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Namespace for test related things.
  */
 var test = test || {};
 
 /**
@@ skipping 13 matching lines @@
     attributes[element.attributes[i].nodeName] =
         element.attributes[i].nodeValue;
   }
   var styles = {};
   var styleNames = opt_styleNames || [];
   var computedStyles = contentWindow.getComputedStyle(element);
   for (var i = 0; i < styleNames.length; i++) {
     styles[styleNames[i]] = computedStyles[styleNames[i]];
   }
   var text = element.textContent;
+  var size = element.getBoundingClientRect();
   return {
     attributes: attributes,
     text: text,
     value: element.value,
     styles: styles,
     // The hidden attribute is not in the element.attributes even if
     // element.hasAttribute('hidden') is true.
-    hidden: !!element.hidden
+    hidden: !!element.hidden,
+    width: Number(element.width),

[yawano, 2016/01/22 05:03:12]

Why don't you simply use renderedWidth? I don't think we need to have this width
attribute here.

[ryoh, 2016/01/22 05:20:49]

It's needed to check both "size":
 - "width/height" for testing that images are loaded correctly.
 - "renderedWidth/renderedHeight" for testing that images are scaled correctly.

There are two canvases before, full-res and device-res,
so all we need to check is only width/height for these two canvases.

We have only a full-res image now,
so we have to check these two attributes instead.

[yawano, 2016/01/22 05:52:04]

I get it. Thank you!

nit: many of other elements don't have width/height fields. How about to rename
this to imageWidth and set it only when element is image? Setting undefined will
be okay if element is not image.

[ryoh, 2016/01/22 06:46:03]

Done.

[yawano, 2016/01/22 07:02:49]

nit: 0 will be set even if the element doesn't have width field.

+    height: Number(element.height),
+    renderedWidth: size.width,
+    renderedHeight: size.height
   };
 }
 
 /**
  * Namespace for test utility functions.
  *
  * Public functions in the test.util.sync and the test.util.async namespaces are
  * published to test cases and can be called by using callRemoteTestUtil. The
  * arguments are serialized as JSON internally. If application ID is passed to
  * callRemoteTestUtil, the content window of the application is added as the
@@ skipping 518 matching lines @@
       return true;
     } else if (test.util.sync[request.func]) {
       sendResponse(test.util.sync[request.func].apply(null, args));
       return false;
     } else {
       console.error('Invalid function name.');
       return false;
     }
   });
 };