Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1608123002: Fix the return type of _TypeRefValidator. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-20 02:54:44 UTC) #2
scheglov
LGTM Thanks, you were right, I was going to use expect(p(b), isTrue), but it was ...
4 years, 11 months ago (2016-01-20 02:56:29 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-20 03:05:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
547df40502ccc5f55317bf52cf92a7e8bd6cc1cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698