Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3325)

Unified Diff: chrome/browser/ui/webui/settings/people_handler_unittest.cc

Issue 1608103002: Settings Rewrite: Fix Opening Sync User login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/people_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/settings/people_handler_unittest.cc b/chrome/browser/ui/webui/settings/people_handler_unittest.cc
index 48db8c87a5da99f9299873e728d95d95018caac2..860e940d70099a653f80078ccb342c89f1106014 100644
--- a/chrome/browser/ui/webui/settings/people_handler_unittest.cc
+++ b/chrome/browser/ui/webui/settings/people_handler_unittest.cc
@@ -399,7 +399,7 @@ TEST_F(PeopleHandlerTest,
EXPECT_CALL(*mock_pss_, IsBackendInitialized()).WillRepeatedly(Return(false));
SetDefaultExpectationsForConfigPage();
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
// We expect a call to settings.SyncPrivateApi.showSyncSetupPage.
EXPECT_EQ(1U, web_ui_.call_data().size());
@@ -448,7 +448,7 @@ TEST_F(PeopleHandlerTest,
.WillOnce(Return(false))
.WillRepeatedly(Return(true));
SetDefaultExpectationsForConfigPage();
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
// It's important to tell sync the user cancelled the setup flow before we
// tell it we're through with the setup progress.
@@ -470,7 +470,7 @@ TEST_F(PeopleHandlerTest,
error_ = GoogleServiceAuthError::AuthErrorNone();
EXPECT_CALL(*mock_pss_, IsBackendInitialized()).WillRepeatedly(Return(false));
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
EXPECT_EQ("settings.SyncPrivateApi.showSyncSetupPage", data.function_name());
std::string page;
@@ -502,7 +502,7 @@ TEST_F(PeopleHandlerNonCrosTest, HandleGaiaAuthFailure) {
EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
.WillRepeatedly(Return(false));
// Open the web UI.
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ASSERT_FALSE(handler_->is_configuring_sync());
}
@@ -513,7 +513,7 @@ TEST_F(PeopleHandlerNonCrosTest, UnrecoverableErrorInitializingSync) {
EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
.WillRepeatedly(Return(false));
// Open the web UI.
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ASSERT_FALSE(handler_->is_configuring_sync());
}
@@ -523,7 +523,7 @@ TEST_F(PeopleHandlerNonCrosTest, GaiaErrorInitializingSync) {
EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
.WillRepeatedly(Return(false));
// Open the web UI.
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ASSERT_FALSE(handler_->is_configuring_sync());
}
@@ -752,7 +752,7 @@ TEST_F(PeopleHandlerTest, ShowSyncSetup) {
SetupInitializedProfileSyncService();
// This should display the sync setup dialog (not login).
SetDefaultExpectationsForConfigPage();
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
}
@@ -787,7 +787,7 @@ TEST_F(PeopleHandlerTest, ShowSigninOnAuthError) {
// On ChromeOS, this should display the spinner while we try to startup the
// sync backend, and on desktop this displays the login dialog.
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
// Sync setup is closed when re-auth is in progress.
EXPECT_EQ(NULL,
@@ -806,7 +806,7 @@ TEST_F(PeopleHandlerTest, ShowSetupSyncEverything) {
SetupInitializedProfileSyncService();
SetDefaultExpectationsForConfigPage();
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -840,7 +840,7 @@ TEST_F(PeopleHandlerTest, ShowSetupManuallySyncAll) {
sync_prefs.SetKeepEverythingSynced(false);
SetDefaultExpectationsForConfigPage();
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -867,7 +867,7 @@ TEST_F(PeopleHandlerTest, ShowSetupSyncForAllTypesIndividually) {
WillRepeatedly(Return(types));
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
// Close the config overlay.
@@ -892,7 +892,7 @@ TEST_F(PeopleHandlerTest, ShowSetupGaiaPassphraseRequired) {
SetDefaultExpectationsForConfigPage();
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -914,7 +914,7 @@ TEST_F(PeopleHandlerTest, ShowSetupCustomPassphraseRequired) {
SetDefaultExpectationsForConfigPage();
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -936,7 +936,7 @@ TEST_F(PeopleHandlerTest, ShowSetupEncryptAll) {
.WillRepeatedly(Return(true));
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -956,7 +956,7 @@ TEST_F(PeopleHandlerTest, ShowSetupEncryptAllDisallowed) {
.WillRepeatedly(Return(false));
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];

Powered by Google App Engine
This is Rietveld 408576698