Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3944)

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc

Issue 1608103002: Settings Rewrite: Fix Opening Sync User login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc b/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
index 7fcc635894a07323a8ded6d3769cc75b53bdad9e..b6a135fdbb1e8e816e6fcff3fd85285e9711f108 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
+++ b/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
@@ -394,7 +394,7 @@ TEST_F(SyncSetupHandlerTest,
EXPECT_CALL(*mock_pss_, IsBackendInitialized()).WillRepeatedly(Return(false));
SetDefaultExpectationsForConfigPage();
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
// We expect a call to SyncSetupOverlay.showSyncSetupPage.
EXPECT_EQ(1U, web_ui_.call_data().size());
@@ -443,7 +443,7 @@ TEST_F(SyncSetupHandlerTest,
.WillOnce(Return(false))
.WillRepeatedly(Return(true));
SetDefaultExpectationsForConfigPage();
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
// It's important to tell sync the user cancelled the setup flow before we
// tell it we're through with the setup progress.
@@ -465,7 +465,7 @@ TEST_F(SyncSetupHandlerTest,
error_ = GoogleServiceAuthError::AuthErrorNone();
EXPECT_CALL(*mock_pss_, IsBackendInitialized()).WillRepeatedly(Return(false));
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
EXPECT_EQ("SyncSetupOverlay.showSyncSetupPage", data.function_name());
std::string page;
@@ -497,7 +497,7 @@ TEST_F(SyncSetupHandlerNonCrosTest, HandleGaiaAuthFailure) {
EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
.WillRepeatedly(Return(false));
// Open the web UI.
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ASSERT_FALSE(handler_->is_configuring_sync());
}
@@ -508,7 +508,7 @@ TEST_F(SyncSetupHandlerNonCrosTest, UnrecoverableErrorInitializingSync) {
EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
.WillRepeatedly(Return(false));
// Open the web UI.
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ASSERT_FALSE(handler_->is_configuring_sync());
}
@@ -518,7 +518,7 @@ TEST_F(SyncSetupHandlerNonCrosTest, GaiaErrorInitializingSync) {
EXPECT_CALL(*mock_pss_, HasSyncSetupCompleted())
.WillRepeatedly(Return(false));
// Open the web UI.
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ASSERT_FALSE(handler_->is_configuring_sync());
}
@@ -741,7 +741,7 @@ TEST_F(SyncSetupHandlerTest, ShowSyncSetup) {
SetupInitializedProfileSyncService();
// This should display the sync setup dialog (not login).
SetDefaultExpectationsForConfigPage();
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
}
@@ -776,7 +776,7 @@ TEST_F(SyncSetupHandlerTest, ShowSigninOnAuthError) {
// On ChromeOS, this should display the spinner while we try to startup the
// sync backend, and on desktop this displays the login dialog.
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
// Sync setup is closed when re-auth is in progress.
EXPECT_EQ(NULL,
@@ -795,7 +795,7 @@ TEST_F(SyncSetupHandlerTest, ShowSetupSyncEverything) {
SetupInitializedProfileSyncService();
SetDefaultExpectationsForConfigPage();
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -830,7 +830,7 @@ TEST_F(SyncSetupHandlerTest, ShowSetupManuallySyncAll) {
sync_prefs.SetKeepEverythingSynced(false);
SetDefaultExpectationsForConfigPage();
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -857,7 +857,7 @@ TEST_F(SyncSetupHandlerTest, ShowSetupSyncForAllTypesIndividually) {
WillRepeatedly(Return(types));
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
// Close the config overlay.
@@ -882,7 +882,7 @@ TEST_F(SyncSetupHandlerTest, ShowSetupGaiaPassphraseRequired) {
SetDefaultExpectationsForConfigPage();
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -904,7 +904,7 @@ TEST_F(SyncSetupHandlerTest, ShowSetupCustomPassphraseRequired) {
SetDefaultExpectationsForConfigPage();
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -926,7 +926,7 @@ TEST_F(SyncSetupHandlerTest, ShowSetupEncryptAll) {
.WillRepeatedly(Return(true));
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -946,7 +946,7 @@ TEST_F(SyncSetupHandlerTest, ShowSetupEncryptAllDisallowed) {
.WillRepeatedly(Return(false));
// This should display the sync setup dialog (not login).
- handler_->OpenSyncSetup(nullptr);
+ handler_->OpenSyncSetup(false /* creating_supervised_user */);
ExpectConfig();
const content::TestWebUI::CallData& data = *web_ui_.call_data()[0];
@@ -977,4 +977,3 @@ TEST_F(SyncSetupHandlerTest, TurnOnEncryptAllDisallowed) {
// passphrase.
ExpectDone();
}
-

Powered by Google App Engine
This is Rietveld 408576698