Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1608083002: In GN, add mojo_js_integration_tests to mojo:tests group. (Closed)

Created:
4 years, 11 months ago by yzshen1
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In GN, add mojo_js_integration_tests to mojo:tests group. BUG=536669 Committed: https://crrev.com/9837025335b38510d505f221edda514e45541bbc Cr-Commit-Position: refs/heads/master@{#370315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Scott. Please take a look. Thanks!
4 years, 11 months ago (2016-01-20 00:48:41 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-20 00:58:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608083002/1
4 years, 11 months ago (2016-01-20 04:34:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 05:16:11 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 05:17:54 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9837025335b38510d505f221edda514e45541bbc
Cr-Commit-Position: refs/heads/master@{#370315}

Powered by Google App Engine
This is Rietveld 408576698