Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1608073002: Revert of Remove MockConstraints (Closed)

Created:
4 years, 11 months ago by samli
Modified:
4 years, 11 months ago
CC:
chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove MockConstraints (patchset #1 id:1 of https://codereview.chromium.org/1605513002/ ) Reason for revert: Appears to be causing fast/mediastream/RTCPeerConnection.html to fail across all bots. Original issue's description: > Remove MockConstraints > > The purpose of the MockConstraints class was to verify that only legal > constraint names were passed. This is now done inside Blink > in MediaConstraintsImpl.cpp, so this class isn't needed any more. > > BUG=543997 > > Committed: https://crrev.com/dc42f8b18dbb9c8fec81e3b7a10ab0186ce36553 > Cr-Commit-Position: refs/heads/master@{#370219} TBR=jochen@chromium.org,tommi@chromium.org,hta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543997 Committed: https://crrev.com/e0dd75ac197c5df17ebe34a5f3295ea54d9e463f Cr-Commit-Position: refs/heads/master@{#370238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -6 lines) Patch
M components/test_runner/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/test_runner/mock_constraints.h View 1 chunk +23 lines, -0 lines 0 comments Download
A components/test_runner/mock_constraints.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M components/test_runner/mock_webrtc_peer_connection_handler.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
samli
Created Revert of Remove MockConstraints
4 years, 11 months ago (2016-01-20 00:25:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608073002/1
4 years, 11 months ago (2016-01-20 00:27:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 00:30:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0dd75ac197c5df17ebe34a5f3295ea54d9e463f Cr-Commit-Position: refs/heads/master@{#370238}
4 years, 11 months ago (2016-01-20 00:31:44 UTC) #5
hta - Chromium
4 years, 11 months ago (2016-01-21 08:43:09 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1614733002/ by hta@chromium.org.

The reason for reverting is: Re-landing with fixed tests..

Powered by Google App Engine
This is Rietveld 408576698