Fixing M33 and M34 stable blocker crash with InsertAppLauncherItem

Fixing M33 and M34 stable blocker crash with InsertAppLauncherItem

The problem appears to be that the function GetLastActiveWebContents returns a WebContents pointer to some content which got already deleted. (See comment from CL).

Note that this is only used in InsertAppLauncherItem to find the activity state. Note that this indicates that we could even get rid of that map and use app_id_to_web_contents to find if a tab is currently active. But again - keeping the CL small for the backport.

This seems to be the most secure and isolated for for M33 and 34 - I will create an issue to follow up on this the proper way.

BUG=341250
TEST=none (no test case known)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250874

[Mr4D (OOO till 08-26), 2014-02-12 19:08:51]

Please have a look!

[James Cook, 2014-02-12 19:23:29]

LGTM with one suggestion

https://codereview.chromium.org/160803002/diff/1/chrome/browser/ui/ash/launch...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/160803002/diff/1/chrome/browser/ui/ash/launch...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:1740: if
(!i->second.size()) {
I think this might be clearer if you stored i->second in a temporary variable.
Also, as it stands it looks like you might not exit the loop (even though you
will).

Maybe something like this would be clearer:

WebContentsList* list = i->second();
while (!list->empty()) {
...
}
app_id_to_web_contents_list_.erase(app_id);
return NULL;

[Mr4D (OOO till 08-26), 2014-02-12 20:39:03]

Done! Many thanks!

https://codereview.chromium.org/160803002/diff/1/chrome/browser/ui/ash/launch...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/160803002/diff/1/chrome/browser/ui/ash/launch...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:1740: if
(!i->second.size()) {
Done!

[Mr4D (OOO till 08-26), 2014-02-12 20:39:07]

The CQ bit was checked by skuhne@chromium.org

[Mr4D (OOO till 08-26), 2014-02-12 20:39:34]

The CQ bit was unchecked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-02-12 20:39:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/160803002/80001

[Mr4D (OOO till 08-26), 2014-02-12 20:39:56]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:56:46]

Change committed as 250874