dart2js cps: Fix return type for native functions.

dart2js cps: Fix return type for native functions.

Native functions would be translated into a ForeignCode instruction,
but the type mask was not set, so its return type was assumed to be
dynamic.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4d93612ca7ba4c1a1d837feab7ae36c34382a204

[asgerf, 2016-01-19 19:22:04]

asgerf@google.com changed reviewers:
+ kmillikin@google.com, sigmund@google.com, sra@google.com

[asgerf, 2016-01-19 19:22:04]

https://codereview.chromium.org/1607993002/diff/20001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right):

https://codereview.chromium.org/1607993002/diff/20001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:1532: final TypeMask storedType;
This field clashed with the .type field inherited from Primitive. But since this
field is final any attempts to reassign it (in type propagation) would instead
change the inherited (un-readable) field from Primitive.

I will open an analyzer feature request to detect this kind of nonsense.

Apart from renaming the field, another solution would be to just never change
its type after initialization (which is essentially what happened before, but in
a very subtle way).

[Siggi Cherem (dart-lang), 2016-01-19 19:26:24]

lgtm

[asgerf, 2016-01-19 21:57:01]

Description was changed from

==========
dart2js cps: Fix return type for native functions.

Native functions would be translated into a ForeignCode instruction,
but the type mask was not set, so its return type was assumed to be
dynamic.

BUG=
==========

to

==========
dart2js cps: Fix return type for native functions.

Native functions would be translated into a ForeignCode instruction,
but the type mask was not set, so its return type was assumed to be
dynamic.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4d93612ca7ba4c1a1d837feab7ae36c34382a204
==========

[asgerf, 2016-01-19 21:57:02]

Committed patchset #3 (id:40001) manually as
4d93612ca7ba4c1a1d837feab7ae36c34382a204 (presubmit successful).