third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp - Issue 1607943004: Change the system font fallback to take lang attributes into account on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

Issue 1607943004: Change the system font fallback to take lang attributes into account on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix TestExpectations for the new test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win7/inspector-protocol/layout-fonts/languages-emoji-rare-glyphs-expected.txt ('k') | third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

index 0564687282805a3959bc4f44b00890e0b0d196c2..b34762474b583cb88d8e45eb0babd6413200017a 100644

--- a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

+++ b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

@@ -128,11 +128,11 @@ PassRefPtr<SimpleFontData> FontCache::fallbackFontForCharacter(

return fontData;

}

- // FIXME: Consider passing fontDescription.dominantScript()

- // to GetFallbackFamily here.

UScriptCode script;

const wchar_t* family = getFallbackFamily(character,

fontDescription.genericFamily(),

+ fontDescription.script(),

+ fontDescription.locale(),

&script,

m_fontManager.get());

FontPlatformData* data = 0;