Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1607943003: [runtime] Introduce maps for the likely cases of FromPropertyDescriptor. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Introduce maps for the likely cases of FromPropertyDescriptor. This change improves performance for the common case of Object.getOwnPropertyDescriptor by up 3x-4x, where we just return a property descriptor object for a regular data or accessor property. CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_rel_ng R=yangguo@chromium.org Committed: https://crrev.com/ffa9e82235b20c523ebb1151c6196bc6232296b9 Cr-Commit-Position: refs/heads/master@{#33398} Committed: https://crrev.com/8e8bd866a47297672cc75e57320bbcff0a77d6f2 Cr-Commit-Position: refs/heads/master@{#33415}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -2 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/objects.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
M src/property-descriptor.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/property-descriptor.cc View 2 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-20 06:56:10 UTC) #1
Benedikt Meurer
Hey Yang, Here's the change to getOwnPropertyDescriptor we talked about. Please take a look. Thanks, ...
4 years, 11 months ago (2016-01-20 06:57:04 UTC) #2
Yang
On 2016/01/20 06:57:04, Benedikt Meurer wrote: > Hey Yang, > > Here's the change to ...
4 years, 11 months ago (2016-01-20 07:52:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607943003/1
4 years, 11 months ago (2016-01-20 07:54:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 07:55:32 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ffa9e82235b20c523ebb1151c6196bc6232296b9 Cr-Commit-Position: refs/heads/master@{#33398}
4 years, 11 months ago (2016-01-20 07:56:33 UTC) #8
Michael Hablich
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1604243002/ by hablich@chromium.org. ...
4 years, 11 months ago (2016-01-20 11:54:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607943003/20001
4 years, 11 months ago (2016-01-20 18:00:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)
4 years, 11 months ago (2016-01-20 18:01:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607943003/20001
4 years, 11 months ago (2016-01-20 18:05:48 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-20 19:04:11 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 19:04:52 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e8bd866a47297672cc75e57320bbcff0a77d6f2
Cr-Commit-Position: refs/heads/master@{#33415}

Powered by Google App Engine
This is Rietveld 408576698