Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1607923004: Hook up show-config to testing scripts. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com, Lei Zhang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : And JS too #

Total comments: 4

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M testing/tools/run_corpus_tests.py View 1 chunk +2 lines, -1 line 0 comments Download
M testing/tools/run_javascript_tests.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 chunk +2 lines, -1 line 0 comments Download
M testing/tools/suppressor.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Pls. review.
4 years, 11 months ago (2016-01-19 21:25:44 UTC) #2
Oliver Chang
lgtm https://codereview.chromium.org/1607923004/diff/20001/testing/tools/run_javascript_tests.py File testing/tools/run_javascript_tests.py (right): https://codereview.chromium.org/1607923004/diff/20001/testing/tools/run_javascript_tests.py#newcode67 testing/tools/run_javascript_tests.py:67: if not "V8" in feature_string.strip().split(","): nit: if "V8" ...
4 years, 11 months ago (2016-01-19 22:51:49 UTC) #3
Tom Sepez
https://codereview.chromium.org/1607923004/diff/20001/testing/tools/run_javascript_tests.py File testing/tools/run_javascript_tests.py (right): https://codereview.chromium.org/1607923004/diff/20001/testing/tools/run_javascript_tests.py#newcode67 testing/tools/run_javascript_tests.py:67: if not "V8" in feature_string.strip().split(","): On 2016/01/19 22:51:49, Oliver ...
4 years, 11 months ago (2016-01-19 22:53:45 UTC) #4
Tom Sepez
4 years, 11 months ago (2016-01-19 22:55:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d40e189ba1ab515ef9b3df7928e215be150df336 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698