Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1607883002: Delete trace_event.h from gpu/ (Closed)

Created:
4 years, 11 months ago by mkollaro
Modified:
4 years, 11 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete trace_event.h from gpu/ Fixes couple of GN warnings similar to this one: ERROR at //gpu/command_buffer/client/gles2_trace_implementation.cc:6:11: Include not allowed. #include "gpu/command_buffer/common/trace_event.h" ^-------------------------------------- It is not in any dependency of //gpu/command_buffer/client:gles2_implementation The include file is in the target(s): //gpu:gpu_unittests which should somehow be reachable. BUG=367595 Committed: https://crrev.com/c0d13d185e7b4d844265d6fc61b39217c4b9cd9c Cr-Commit-Position: refs/heads/master@{#370350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
D gpu/command_buffer/common/trace_event.h View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
mkollaro
4 years, 11 months ago (2016-01-19 14:31:04 UTC) #2
no sievers
lgtm
4 years, 11 months ago (2016-01-19 19:12:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607883002/1
4 years, 11 months ago (2016-01-20 08:12:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 08:53:52 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 08:54:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0d13d185e7b4d844265d6fc61b39217c4b9cd9c
Cr-Commit-Position: refs/heads/master@{#370350}

Powered by Google App Engine
This is Rietveld 408576698