Serialize namespaced type/* selectors according to CSSOM spec.

Serialize namespaced type/* selectors according to CSSOM spec.

See https://drafts.csswg.org/cssom/#serializing-selectors.

The serialize-namespaced-type-selectors.html test is a stripped version
of this pull request: https://github.com/w3c/csswg-test/pull/1020
Gecko (Firefox 43) passes all those tests.

As part of this we are fixing problems with universal selectors being
incorrectly marked as explicit (for serialization) in certain cases.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit due to an incorrect isNull() check. Explicit
universal selectors were already dropped from the serialization of
selectors like *::before.

BUG=579043
Committed: https://crrev.com/8f87ec8f7a65cb767447dc5e173c5e71589fd8e8
Cr-Commit-Position: refs/heads/master@{#371363}

[kochi, 2016-01-20 07:12:07]

kochi@chromium.org changed reviewers:
+ kochi@chromium.org

[kochi, 2016-01-20 07:12:08]

In the description
> video::cue(i) can add the combinator between div and ::shadow,

is meant to be "... the combinator between video and ::cue(i),"?

[rune, 2016-01-20 10:32:42]

Description was changed from

==========
Universal selector incorrectly marked as explicit.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between div and ::shadow, while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit. Explicit universal selectors were already dropped
from the serialization of selectors like *::before.

Added some tests to check that we are preserving universal and default
namespaces for universal selectors.

R=timloh@chromium.org
BUG=579043
==========

to

==========
Universal selector incorrectly marked as explicit.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit. Explicit universal selectors were already dropped
from the serialization of selectors like *::before.

Added some tests to check that we are preserving universal and default
namespaces for universal selectors.

R=timloh@chromium.org
BUG=579043
==========

[rune, 2016-01-20 10:32:54]

On 2016/01/20 07:12:08, kochi wrote:
> In the description
> > video::cue(i) can add the combinator between div and ::shadow,
> 
> is meant to be "... the combinator between video and ::cue(i),"?

Fixed.

[kochi, 2016-01-20 10:51:23]

non-owner LGTM

[rune, 2016-01-20 17:45:46]

The CQ bit was checked by rune@opera.com

[rune, 2016-01-20 17:45:46]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1607873002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-01-20 17:46:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607873002/20001

[commit-bot: I haz the power, 2016-01-20 18:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 18:57:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kochi, 2016-01-21 00:51:20]

On 2016/01/20 18:57:23, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Seems my previous CL's fast/dom/shadow/slotted-pseudo-element-css-text.html
caused this.
Could you remove a '*' in the file and CQ again?

[rune, 2016-01-21 08:03:42]

On 2016/01/21 00:51:20, kochi wrote:
> On 2016/01/20 18:57:23, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> Seems my previous CL's fast/dom/shadow/slotted-pseudo-element-css-text.html
> caused this.
> Could you remove a '*' in the file and CQ again?

The other fail shows I've introduced an explicit '*' in the serialization when
there are default @namespace rules involved, so I need to rework this one. I'll
keep a closer look at the CSSOM spec (and Gecko) as well, which actually
specifies how the serialization should work.

[rune, 2016-01-22 23:21:47]

Description was changed from

==========
Universal selector incorrectly marked as explicit.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit. Explicit universal selectors were already dropped
from the serialization of selectors like *::before.

Added some tests to check that we are preserving universal and default
namespaces for universal selectors.

R=timloh@chromium.org
BUG=579043
==========

to

==========
Serialize namespaced type/* selectors according to CSSOM spec.

See https://drafts.csswg.org/cssom/#serializing-selectors.

The serialize-namespaced-type-selectors.html test is a stripped version
of this pull request: https://github.com/w3c/csswg-test/pull/1020
Gecko (Firefox 43) passes all those tests.

As part of this we are fixing problems with universal selectors being
incorrectly marked as explicit (for serialization) in certain cases.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit due to an incorrect isNull() check. Explicit
universal selectors were already dropped from the serialization of
selectors like *::before.

BUG=579043
==========

[rune, 2016-01-22 23:26:30]

On 2016/01/21 08:03:42, rune wrote:
> On 2016/01/21 00:51:20, kochi wrote:

> > Seems my previous CL's fast/dom/shadow/slotted-pseudo-element-css-text.html
> > caused this.
> > Could you remove a '*' in the file and CQ again?
> 
> The other fail shows I've introduced an explicit '*' in the serialization when
> there are default @namespace rules involved, so I need to rework this one.
I'll
> keep a closer look at the CSSOM spec (and Gecko) as well, which actually
> specifies how the serialization should work.

Fixed this more thoroughly now. Needs another round of reviews.

[kochi, 2016-01-25 04:21:54]

https://codereview.chromium.org/1607873002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-css-text.html
(right):

https://codereview.chromium.org/1607873002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-css-text.html:8:
::slotted(*) { display: block; }
Please keep the prefix "*" here.
Otherwise this test case is the same as line 7.

[rune, 2016-01-25 09:33:17]

https://codereview.chromium.org/1607873002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-css-text.html
(right):

https://codereview.chromium.org/1607873002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-css-text.html:8:
::slotted(*) { display: block; }
On 2016/01/25 04:21:53, kochi wrote:
> Please keep the prefix "*" here.
> Otherwise this test case is the same as line 7.

Ooops. That was not intentional.

Fixed in PS6.

[kochi, 2016-01-25 20:20:38]

lgtm

[rune, 2016-01-25 21:58:59]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-01-25 22:00:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607873002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607873002/100001

[commit-bot: I haz the power, 2016-01-25 22:07:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 22:07:08]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rune, 2016-01-25 22:32:05]

The CQ bit was checked by rune@opera.com

[rune, 2016-01-25 22:32:05]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1607873002/#ps120001
(title: "Rebased")

[commit-bot: I haz the power, 2016-01-25 22:33:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607873002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607873002/120001

[commit-bot: I haz the power, 2016-01-26 00:12:37]

Description was changed from

==========
Serialize namespaced type/* selectors according to CSSOM spec.

See https://drafts.csswg.org/cssom/#serializing-selectors.

The serialize-namespaced-type-selectors.html test is a stripped version
of this pull request: https://github.com/w3c/csswg-test/pull/1020
Gecko (Firefox 43) passes all those tests.

As part of this we are fixing problems with universal selectors being
incorrectly marked as explicit (for serialization) in certain cases.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit due to an incorrect isNull() check. Explicit
universal selectors were already dropped from the serialization of
selectors like *::before.

BUG=579043
==========

to

==========
Serialize namespaced type/* selectors according to CSSOM spec.

See https://drafts.csswg.org/cssom/#serializing-selectors.

The serialize-namespaced-type-selectors.html test is a stripped version
of this pull request: https://github.com/w3c/csswg-test/pull/1020
Gecko (Firefox 43) passes all those tests.

As part of this we are fixing problems with universal selectors being
incorrectly marked as explicit (for serialization) in certain cases.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit due to an incorrect isNull() check. Explicit
universal selectors were already dropped from the serialization of
selectors like *::before.

BUG=579043
==========

[commit-bot: I haz the power, 2016-01-26 00:12:37]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-01-26 00:15:01]

Description was changed from

==========
Serialize namespaced type/* selectors according to CSSOM spec.

See https://drafts.csswg.org/cssom/#serializing-selectors.

The serialize-namespaced-type-selectors.html test is a stripped version
of this pull request: https://github.com/w3c/csswg-test/pull/1020
Gecko (Firefox 43) passes all those tests.

As part of this we are fixing problems with universal selectors being
incorrectly marked as explicit (for serialization) in certain cases.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit due to an incorrect isNull() check. Explicit
universal selectors were already dropped from the serialization of
selectors like *::before.

BUG=579043
==========

to

==========
Serialize namespaced type/* selectors according to CSSOM spec.

See https://drafts.csswg.org/cssom/#serializing-selectors.

The serialize-namespaced-type-selectors.html test is a stripped version
of this pull request: https://github.com/w3c/csswg-test/pull/1020
Gecko (Firefox 43) passes all those tests.

As part of this we are fixing problems with universal selectors being
incorrectly marked as explicit (for serialization) in certain cases.

When we have pseudo elements which require an implicit shadow combinator
to match across shadow boundaries, we need to add an implicit universal
selector to make the combinator combine the pseudo with some parent when
the original selector doesn't have any other simple selectors.

video::cue(i) can add the combinator between video and ::cue(i), while
::cue(i) requires a universal selector in the internal representation
to have ::cue(i) -> /implicit-shadow-crossing/ -> *.

For ::cue(i), the universal selector were marked correctly as implicit
to avoid it being serialized as *::cue(i). However, with an explicit
universal selector in the source *::cue(i), the universal selector were
marked as explicit due to an incorrect isNull() check. Explicit
universal selectors were already dropped from the serialization of
selectors like *::before.

BUG=579043

Committed: https://crrev.com/8f87ec8f7a65cb767447dc5e173c5e71589fd8e8
Cr-Commit-Position: refs/heads/master@{#371363}
==========

[commit-bot: I haz the power, 2016-01-26 00:15:02]

Patchset 7 (id:??) landed as
https://crrev.com/8f87ec8f7a65cb767447dc5e173c5e71589fd8e8
Cr-Commit-Position: refs/heads/master@{#371363}