Issue 1607833004: [MD settings] fix for opening sync user login

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1607833004: [MD settings] fix for opening sync user login (Closed)

Created:
4 years, 11 months ago by dschuyler

Modified:
4 years, 11 months ago

Reviewers:
tommycli

CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[MD settings] fix for opening sync user login This CL fixes a check (crash) when clicking Sign into Chrome in the user settings in chrome://md-settings. BUG=None

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/ui/webui/settings/people_handler.cc	View		3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dschuyler

Tommy, other calls to OpenSyncSetup pass nullptr rather than args. It appears to work in ...

4 years, 11 months ago (2016-01-19 20:08:48 UTC) #2

tommycli

4 years, 11 months ago (2016-01-19 20:21:44 UTC) #3

On 2016/01/19 20:08:48, dschuyler wrote:
> Tommy, other calls to OpenSyncSetup pass nullptr rather than args.  It appears
> to work in this case too.  PTAL and let me know if you feel this is or isn't
the
> right thing to do here.

Hi Dave, it looks like the OpenSyncSetup method body does do something with the
'args' param, but I'm not sure what right now. I will have to dive deeper into
this to figure out where I went wrong. Thanks.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages