Fix crash when using disallowed URLs in image sets for content CSS property

Fix crash when using disallowed URLs in image sets for content CSS property

This change makes CSSImageSetValue::cacheImage() always cache a StyleImage
instead of caching nullptr when the ImageResource::fetch() call fails.
After this change a StyleInvalidImage will be cached if fetch() fails.

BUG=578997
Committed: https://crrev.com/e56bf13bcbf5e51897e52a77a9334b377f8528ac
Cr-Commit-Position: refs/heads/master@{#370346}

[alancutter (OOO until 2018), 2016-01-20 04:07:00]

Description was changed from

==========
+fixStyleInvalidImageCrash

BUG=578997
==========

to

==========
Fix crash when using disallowed URLs in image sets for content CSS property

This change makes CSSImageSetValue always cache a StyleImage instead of
caching nullptr when the ImageResource::fetch() call fails.
After this change a StyleInvalidImage will be cached if fetch() fails.

BUG=578997
==========

[alancutter (OOO until 2018), 2016-01-20 04:07:00]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2016-01-20 04:07:41]

Description was changed from

==========
Fix crash when using disallowed URLs in image sets for content CSS property

This change makes CSSImageSetValue always cache a StyleImage instead of
caching nullptr when the ImageResource::fetch() call fails.
After this change a StyleInvalidImage will be cached if fetch() fails.

BUG=578997
==========

to

==========
Fix crash when using disallowed URLs in image sets for content CSS property

This change makes CSSImageSetValue::cacheImage() always cache a StyleImage
instead of caching nullptr when the ImageResource::fetch() call fails.
After this change a StyleInvalidImage will be cached if fetch() fails.

BUG=578997
==========

[alancutter (OOO until 2018), 2016-01-20 04:07:46]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 04:09:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607733004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607733004/1

[Timothy Loh, 2016-01-20 04:40:15]

ok lgtm

[commit-bot: I haz the power, 2016-01-20 04:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 04:48:19]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[alancutter (OOO until 2018), 2016-01-20 06:10:13]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-01-20 06:10:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607733004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607733004/1

[commit-bot: I haz the power, 2016-01-20 08:51:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-20 08:52:01]

Description was changed from

==========
Fix crash when using disallowed URLs in image sets for content CSS property

This change makes CSSImageSetValue::cacheImage() always cache a StyleImage
instead of caching nullptr when the ImageResource::fetch() call fails.
After this change a StyleInvalidImage will be cached if fetch() fails.

BUG=578997
==========

to

==========
Fix crash when using disallowed URLs in image sets for content CSS property

This change makes CSSImageSetValue::cacheImage() always cache a StyleImage
instead of caching nullptr when the ImageResource::fetch() call fails.
After this change a StyleInvalidImage will be cached if fetch() fails.

BUG=578997

Committed: https://crrev.com/e56bf13bcbf5e51897e52a77a9334b377f8528ac
Cr-Commit-Position: refs/heads/master@{#370346}
==========

[commit-bot: I haz the power, 2016-01-20 08:52:02]

Patchset 1 (id:??) landed as
https://crrev.com/e56bf13bcbf5e51897e52a77a9334b377f8528ac
Cr-Commit-Position: refs/heads/master@{#370346}