Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 160773002: Add note about dev channel UseCount skew to dashboard summary. (Closed)

Created:
6 years, 10 months ago by pdr.
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add note about dev channel UseCount skew to dashboard summary. This patch adds a note to the FeatureObserver summary in histograms.xml about the incorrect numbers due to crbug.com/341631. BUG=341631 Committed: https://crrev.com/49ce0fa0fdef9a601026c0b817330e07705b6841 Cr-Commit-Position: refs/heads/master@{#295921}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reword message a bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (1 generated)
pdr.
6 years, 10 months ago (2014-02-12 18:56:02 UTC) #1
Ilya Sherman
LGTM % nit. Thanks. https://codereview.chromium.org/160773002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/160773002/diff/1/tools/metrics/histograms/histograms.xml#newcode21818 tools/metrics/histograms/histograms.xml:21818: + crbug.com/341631: dev numbers from ...
6 years, 10 months ago (2014-02-12 22:39:55 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 10 months ago (2014-02-13 01:28:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/160773002/50001
6 years, 10 months ago (2014-02-13 01:33:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 02:41:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-13 02:41:42 UTC) #6
Ilya Sherman
Hi, what's the status of this CL?
6 years, 3 months ago (2014-09-20 01:02:47 UTC) #7
pdr.
On 2014/09/20 01:02:47, Ilya Sherman wrote: > Hi, what's the status of this CL? I ...
6 years, 3 months ago (2014-09-22 03:00:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/160773002/50001
6 years, 3 months ago (2014-09-22 03:01:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:50001) as 5675f345b7fbf5885b069e65a8ccc1a3c2aa1014
6 years, 3 months ago (2014-09-22 03:59:27 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 03:59:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49ce0fa0fdef9a601026c0b817330e07705b6841
Cr-Commit-Position: refs/heads/master@{#295921}

Powered by Google App Engine
This is Rietveld 408576698