Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 1607703003: Don't force display:inline-table/table on table elements when in quirks mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
index 406d71f0bdece217b9e7e58b06cb659a1e67f55f..b7fa74ba72f5982ddad67040225f612abc964ee3 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
@@ -365,7 +365,7 @@ void StyleAdjuster::adjustStyleForHTMLElement(ComputedStyle& style, const Comput
if (isHTMLTableElement(element)) {
// Sites commonly use display:inline/block on <td>s and <table>s. In quirks mode we force
// these tags to retain their display types.
- if (m_useQuirksModeStyles)
+ if (m_useQuirksModeStyles && style.display() != INLINE)
style.setDisplay(style.isDisplayInlineType() ? INLINE_TABLE : TABLE);
rune 2016/01/19 09:54:51 We should just drop this whole quirk altogether, I
nainar 2016/01/19 10:44:11 I looked up the quirks spec - this isn't mentioned
nainar 2016/01/20 00:44:23 Done.
// Tables never support the -webkit-* values for text-align and will reset back to the default.
if (style.textAlign() == WEBKIT_LEFT || style.textAlign() == WEBKIT_CENTER || style.textAlign() == WEBKIT_RIGHT)

Powered by Google App Engine
This is Rietveld 408576698