Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1607653002: Remove getComputedStyle(e).css* properties (Closed)

Created:
4 years, 11 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 11 months ago
Reviewers:
haraken, Timothy Loh
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove getComputedStyle(e).css* properties Having deprecated the getComputedStyle(e).css* properties, this patch removes the capability completely. Affected tests are updated (and the deprecation-specific test is removed), and the UseCounter is removed since it is no longer needed. BUG=413205 Committed: https://crrev.com/b7e1bea8744c389a7e28fc798be3ce40ba189a3d Cr-Commit-Position: refs/heads/master@{#370215}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary property name prefix check #

Messages

Total messages: 15 (5 generated)
suzyh_UTC10 (ex-contributor)
4 years, 11 months ago (2016-01-19 02:19:56 UTC) #2
Timothy Loh
https://codereview.chromium.org/1607653002/diff/1/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp File third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp (right): https://codereview.chromium.org/1607653002/diff/1/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp#newcode94 third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp:94: if (hasCSSPropertyNamePrefix(propertyName, "css")) We don't really need to check ...
4 years, 11 months ago (2016-01-19 02:25:15 UTC) #3
suzyh_UTC10 (ex-contributor)
https://codereview.chromium.org/1607653002/diff/1/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp File third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp (right): https://codereview.chromium.org/1607653002/diff/1/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp#newcode94 third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp:94: if (hasCSSPropertyNamePrefix(propertyName, "css")) On 2016/01/19 at 02:25:15, Timothy Loh ...
4 years, 11 months ago (2016-01-19 02:29:43 UTC) #4
Timothy Loh
lgtm
4 years, 11 months ago (2016-01-19 02:33:44 UTC) #5
haraken
bindings LGTM
4 years, 11 months ago (2016-01-19 02:47:21 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607653002/20001
4 years, 11 months ago (2016-01-19 02:48:43 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-19 03:58:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607653002/20001
4 years, 11 months ago (2016-01-19 22:42:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-19 22:51:40 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 22:52:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7e1bea8744c389a7e28fc798be3ce40ba189a3d
Cr-Commit-Position: refs/heads/master@{#370215}

Powered by Google App Engine
This is Rietveld 408576698